-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent variable_init from retuning an empty array. #37
base: master
Are you sure you want to change the base?
Conversation
I see only one new line and a bunch of white spaces. :) |
There are 41 additions and 21 deletions; that means we have 20 new lines. About 2/3 of the new lines are comments, but there is a fair share of new code. The new logic that is inserted in 2 different places deals with this chunk of code. Click on the diff button above next to Discussion & Commits to see the diff. Or to see the issue on d.o go here http://drupal.org/node/561990#comment-5803696
|
Sorry, I did not want to be rude. The white spaces just caught my eyes. I really appreciate the work you do for the Drupal community through many great modules. |
White space fixes are a result of the editor I have (kate) :) It removes trailing white space at the end of a line. http://drupal.org/coding-standards#indenting |
… an empty array.
… unlink() No such file or directory in file_delete()
…build_filter_query()
…ng _menu_load_objects()
… (race condition)
Unknown error: Function split() is deprecated in _filter_autop()
…ccess() skip it right away.
…val in .htaccess
…ails. Add in the ability to handle this gracefully (don't always call _db_error_page).
…ootstrap modules twice
…stall node/1 and has no static cache.
… FILE_EXISTS_REPLACE
…data with update_sql()
…OWED_PACKET errors because they're longer than MAX_ALLOWED_PACKET
…batch-inserting book pages
Hello, Thanks for the patch MickeyTown, it is really usefull on our production server. I've juste a small question about releasing the lock when we detect a FALSE result. Shouldn't we do something like that (if false then release lock):
Thanks for any advice. regards, Dimitri |
Patch does a couple of things